Make EnumSet not silently corrupt data. #18721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. |
|
|
|
Worse, this was actually invoking UB with out current bitshift semantics! Thanks for catching this! I basically rewrote EnumSet in #18605 to bring it closer to our new Set conventions, you may want to rebase your work on that. (also if you want to sanity check that that refactor is "right" for this type, I wouldn't mind that!) |
|
Looks good to me, I've r+'d and this can be rebased once the rollup lands |
Assert at run time instead. Fixes rust-lang#13756. I’d rather have this be detected at compile-time, but I don’t know how to do that.
SimonSapin
force-pushed
the
safer-enumset
branch
from
fd7fe37 to
d8ab2f8
Compare
|
Rebased. |
bors
added a commit
that referenced
this pull request
Nov 7, 2014
Assert at run time instead. Fixes #13756. I’d rather have this be detected at compile-time, but I don’t know how to do that.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assert at run time instead. Fixes #13756.
I’d rather have this be detected at compile-time, but I don’t know how to do that.